-
Notifications
You must be signed in to change notification settings - Fork 13.1k
[FIX] E2E issues #20704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] E2E issues #20704
Conversation
|
@ggazzo FYI, At least in RC 3.12.0-rc1 all messages are saved completely unencrypted into the database regardless of the state of the E2E-option on the channel. |
|
@Gummikavalier This is a critical bug. Do you mind explaining this regression in a new issue? I've seen #20596, but I believe it's unrelated. |
|
@tassoevan Yes that other E2E issue is unrelated to this. What I did after updating our test environment from 3.11.1 to 3.12-rc.1 was that I started testing whether that other bug was fixed or not. It wasn't but I also happened to test whether pointing with At this point I checked new messages of both my direct E2E test room and E2E group test room in the database, and noticed msg field in new test messages were unencrypted plain text. To troubleshoot further I disabled existing E2E on the group channel, enabled it again as well as ran few F5s in between for participants web clients to reset the situation after disabling and enabling again. Both participants saw green key go off and back on as they should. After both had green key on again, I sent few more messages on the group channel and checked the database, and I saw that all new messages were still unencrypted. After I restored our test instance from a VM snapshot back to 3.11.1, I tested E2E again on it, and there msg fields were getting encrypted properly. |
|
If necessary and messages in your test systems are properly encrypted in the database, I can have another look with 3.12-rc.1 for comparison. It is only few minutes of work with VM snapshots. |
|
I didn't read first line correctly, I'll create a new issue about this with the above explanation. :) |
please check #20922 I think it solves your problem |
|
@ggazzo Thanks! Unfortunately the issue is fixed in admin E2E-enabled channels but when I enabled E2E as regular owner on a group channel, the message content stays still unencrypted. |
|
Difference of the two:
|
|
I can confirm that the issue happens on 3.12.0 when E2E is enabled by common owner of the room. Should the owner be also admin on the RC instance, it works. |
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments